Fix store context #2161
Merged
Fix store context #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwiname
force-pushed
the
fix-store-context
branch
from
4c75869
to
2857ade
Compare
jiqiang90
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2153 Moved the store into its own class, this resulted in changing of the closure/context meaning that when the block height (and operationStack) was set it would not be updated in the context of the store class. This was causing workers to fail to init because the block height was not yet set.
This PR adds a context to the Store so that it can use the dynamic values.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist