Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ts manifest build failing because of missing deps #2118

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

stwiname
Copy link
Collaborator

Description

A lot of users have been reporting this issue:
Screenshot 2023-10-24 at 10 56 41 AM

Instead of running another command and expecting ts-node to exist we now instead add typescript as a dependency. This fixes commands run from outside of a project directory from the global install.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@stwiname stwiname force-pushed the fix-ts-manifest-build branch from beda318 to 0f1418d Compare October 23, 2023 23:57
@stwiname stwiname force-pushed the fix-ts-manifest-build branch from 783fc8c to 044ea3a Compare October 24, 2023 04:16
@stwiname stwiname marked this pull request as ready for review October 24, 2023 04:17
@jiqiang90 jiqiang90 merged commit 29a2c51 into main Oct 24, 2023
1 of 2 checks passed
@stwiname stwiname deleted the fix-ts-manifest-build branch March 21, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants