Update deploy errorHandler #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwiname
reviewed
Oct 18, 2023
| @@ -30,9 +30,7 @@ export default class Delete extends Command { | |||
| deploymentID = await valueOrPrompt(deploymentID, 'Enter deployment ID', 'Deployment ID is required'); | |||
|
|
|||
| this.log(`Removing deployment: ${deploymentID}`); | |||
| const delete_output = await deleteDeployment(org, project_name, authToken, +deploymentID, ROOT_API_URL_PROD).catch( | |||
| (e) => this.error(e) | |||
There was a problem hiding this comment.
What did this.error do? Was that something from old oclif?
| @@ -219,7 +225,7 @@ export async function uploadFile( | |||
| } | |||
| }) | |||
| .catch((e) => { | |||
| throw new Error(`Publish project to default failed, ${e}`); | |||
| throw new Error(`ipfs write Publish project to default failed, ${e}`); | |||
There was a problem hiding this comment.
Is this right? Maybe fix the casing?
stwiname
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Should provide users with more readable error logging
Type of change
Please delete options that are not relevant.
Checklist