Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip managing connection pool for single endpoint #2091

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

ianhe8x
Copy link
Collaborator

@ianhe8x ianhe8x commented Oct 11, 2023

Description

I have encountered connection recovering issue when single endpoint was used, and the total connections was drop to 0.

This pr is to skip that part of logic.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@stwiname stwiname merged commit a765b3c into main Oct 11, 2023
1 of 2 checks passed
@ianhe8x ianhe8x deleted the skip-conn-pool-for-single-ep branch October 11, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants