Endblock feature #2064
Endblock feature #2064
Conversation
| ], | ||
| ], | ||
| [201, [{startBlock: 1, endBlock: 300}]], | ||
| [301, []], |
There was a problem hiding this comment.
If this can happen then the indexer will exit because of
subql/packages/node-core/src/indexer/blockDispatcher/base-block-dispatcher.ts
Lines 212 to 215 in 5c3142b
We either need to support this correctly in the fetch service when enqueuing blocks or throw an error if this happens
There was a problem hiding this comment.
If no datasources are available to index a specific blockheight we throw this error:
should we change this behaviour to somehow skip blocks that has no datasources?
There was a problem hiding this comment.
I think that happens too late on having to index to that height to see the error.
I think we can skip blocks, its should be relatively easy to do
| [ | ||
| 1, | ||
| { | ||
| dataSources: [{startBlock: 1}], |
There was a problem hiding this comment.
This is a pre-existing bug buy if this change is made then it will produce a different result but the expected result is as it is now
| dataSources: [{startBlock: 1}], | |
| dataSources: [{startBlock: 1}, {startBlock: 200}], |
| const minStartHeight = sortedEvents[0].block; | ||
| [...dsMap.entries()].forEach(([height, ds]) => { | ||
| if (height >= minStartHeight) dsMap.delete(height); | ||
| }); |
There was a problem hiding this comment.
Rather than deleting, why not look forward to the next project and filter based on that?
| @@ -208,6 +208,12 @@ export abstract class BaseBlockDispatcher<Q extends IQueue, DS> implements IBloc | |||
| // Flush all data from cache and wait | |||
| await this.storeCacheService.flushCache(false, true); | |||
| } | |||
|
|
|||
| if (!(await this.projectService.hasDataSourcesAfterHeight(height))) { | |||
There was a problem hiding this comment.
I'm not sure this is right. What happens if we run into bypassblocks at the next height?
There was a problem hiding this comment.
maybe we can do this check with datasources map to make sure we are not exiting prematurely
|
Docs for review subquery/documentation#443 |
Description
Allow an optional endBlock on the datasource. Handlers in that datasource will only run from startBlock to endBlock
Fixes #2008
Type of change
Please delete options that are not relevant.
Checklist