Fix for unstructured storage abis (codegen) #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwiname
reviewed
Aug 29, 2023
| // example: "TextChanged_bytes32_string_string_string_Event", Event name/Function type name will be joined in ejs | ||
| const inputToSnake: string = abiObject.inputs.map((obj) => obj.type.toLowerCase()).join('_'); | ||
| const inputToSnake = abiObject.inputs | ||
| .map((obj) => (obj.type.includes('[]') ? obj.type.replace(/\[\]/g, '_arr') : obj.type.toLowerCase())) |
There was a problem hiding this comment.
The includes check is redundant. If there's no match it wont replace and we should lowercase even if there's an []
stwiname
reviewed
Aug 29, 2023
stwiname
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1975
Fix incorrect codegen on unstructured storage proxy contract abi
Type of change
Please delete options that are not relevant.
Checklist