Fix metadata increment values using actual values to increment by

packages/node-core/src/indexer/storeCache/cacheMetadata.spec.ts

@@ -0,0 +1,26 @@
+// Copyright 2020-2023 SubQuery Pte Ltd authors & contributors
+// SPDX-License-Identifier: GPL-3.0
+
+import {CacheMetadataModel} from './cacheMetadata';
+
+const incrementKey = 'processedBlockCount';
+
+describe('CacheMetadata', () => {
+  let cacheMetadata: CacheMetadataModel;
+
+  beforeEach(() => {
+    cacheMetadata = new CacheMetadataModel(null as any);
+  });
+
+  // Clearing the cache used to set the setCache and getCache to the same empty object
+  // The set cache has increment amounts while the get cache has the actual value
+  it('clears the caches properly', () => {
+    cacheMetadata.clear();
+
+    (cacheMetadata as any).getCache[incrementKey] = 100;
+
+    cacheMetadata.setIncrement(incrementKey);
+
+    expect((cacheMetadata as any).setCache[incrementKey]).toBe(1);
+  });
+});

packages/node-core/src/indexer/storeCache/cacheMetadata.ts

@@ -3,6 +3,7 @@
 
 import assert from 'assert';
 import {Transaction} from '@subql/x-sequelize';
+import {getLogger} from '../..//logger';
 import {hasValue} from '../../utils';
 import {Metadata, MetadataKeys, MetadataRepo} from '../entities';
 import {Cacheable} from './cacheable';
@@ -139,7 +140,7 @@ export class CacheMetadataModel extends Cacheable implements ICachedModelControl
       newSetCache.lastProcessedHeight = this.setCache.lastProcessedHeight;
       this.flushableRecordCounter = 1;
     }
-    this.setCache = newSetCache;
-    this.getCache = newSetCache;
+    this.setCache = {...newSetCache};
+    this.getCache = {...newSetCache};
   }
 }