-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not index data when fullBlock does not exist logs #350
Conversation
Coverage reportCaution Test run failed
Test suite run failedFailed tests: 1/96. Failed suites: 1/14.
Report generated by 🧪jest coverage report action from 34b3237 |
@@ -367,6 +368,11 @@ describe('Api.ethereum', () => { | |||
expect(isFullBlock(blockData)).toBeTruthy(); | |||
expect(isFullBlock(lightBlock)).toBeFalsy(); | |||
|
|||
// block with transactions, but no logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better test would find a real block with no logs.
packages/node/CHANGELOG.md
Outdated
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
|||
### Fixed | |||
- Do not index data when fullBlock does not exist logs (#350) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense to me. It should still be possible to index a block without logs
Description
Do not index data when fullBlock does not exist logs.
Fixes subquery#2575
Type of change
Please delete options that are not relevant.
Checklist