Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default yargs override nodeOptions #166

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix default yargs override nodeOptions #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
936df43
fix default yargs override nodeOptions
jiqiang90 Sep 15, 2023
44918a7
changelog
jiqiang90 Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fix yargs default override runner nodeOptions (#166)

## [2.12.5] - 2023-09-12
### Fixed
- Fix nestjs-prometheus dependency issue (#163)
Expand Down
2 changes: 1 addition & 1 deletion packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@nestjs/schedule": "^3.0.1",
"@subql/common": "2.6.0",
"@subql/common-ethereum": "workspace:*",
"@subql/node-core": "^4.2.8",
"@subql/node-core": "^4.2.9",
"@subql/testing": "^2.0.0",
"@subql/types": "^2.1.4",
"@subql/types-ethereum": "workspace:*",
Expand Down
2 changes: 0 additions & 2 deletions packages/node/src/yargs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ export const yargsOptions = yargs(hideBin(process.argv))
},
'disable-historical': {
demandOption: false,
default: false,
describe: 'Disable storing historical state entities',
type: 'boolean',
},
Expand Down Expand Up @@ -403,7 +402,6 @@ export const yargsOptions = yargs(hideBin(process.argv))
},
'unfinalized-blocks': {
demandOption: false,
default: false,
describe: 'Enable to fetch and index unfinalized blocks',
type: 'boolean',
},
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3054,9 +3054,9 @@ __metadata:
languageName: node
linkType: hard

"@subql/node-core@npm:^4.2.8":
version: 4.2.8
resolution: "@subql/node-core@npm:4.2.8"
"@subql/node-core@npm:^4.2.9":
version: 4.2.9
resolution: "@subql/node-core@npm:4.2.9"
dependencies:
"@apollo/client": ^3.7.16
"@nestjs/common": ^9.4.0
Expand All @@ -3082,7 +3082,7 @@ __metadata:
tar: ^6.1.11
vm2: ^3.9.19
yargs: ^16.2.0
checksum: 5da5408d4401d82392b3a5b49ba864a81b4ba3dc2647380818bb4a05612bb264d0d15c5fc4887af7122c51d420a86a2e4af48d6c452058000cb1371f4ddfe325
checksum: be099b07674e01c7bd75baa5694dd58d7f6103c6164a32fa610e5e8a96bd3c2160852456d33bc005e6fabe8d01e8fa99580d7db26e9bdb4083605e42524d7e26
languageName: node
linkType: hard

Expand All @@ -3100,7 +3100,7 @@ __metadata:
"@nestjs/testing": ^9.4.0
"@subql/common": 2.6.0
"@subql/common-ethereum": "workspace:*"
"@subql/node-core": ^4.2.8
"@subql/node-core": ^4.2.9
"@subql/testing": ^2.0.0
"@subql/types": ^2.1.4
"@subql/types-ethereum": "workspace:*"
Expand Down
Loading