Fallback from batch provider to singular provider #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guplersaxanoid
changed the title
Coverage report
Test suite run success31 tests passing in 5 suites. Report generated by 🧪jest coverage report action from 84ea4dd |
stwiname
reviewed
Aug 17, 2023
| this.name = network.name; | ||
| } catch (e) { | ||
| //batch request error for filecoin | ||
| if (e.message.includes('"message":"we can\'t execute this request"')) { |
There was a problem hiding this comment.
This would only work for filecoin. Other RPC providers might do other things.
I think we should change this error handling. Maybe we can go off the http code or if its not a json rpc response
stwiname
reviewed
Aug 20, 2023
| @@ -144,8 +144,7 @@ export class EthereumApi implements ApiWrapper<EthereumBlockWrapper> { | |||
| this.chainId = network.chainId; | |||
| this.name = network.name; | |||
| } catch (e) { | |||
| //batch request error for filecoin | |||
| if (e.message.includes('"message":"we can\'t execute this request"')) { | |||
| if ((e as Error).message.startsWith('Invalid response')) { | |||
There was a problem hiding this comment.
Does this check against an Ethers error?
There was a problem hiding this comment.
This is how JsonRpcBatchProvider class intercepts invalid responses
stwiname
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the ETH sdk we use the batch http provider by default. Some RPC endpoints don't support batch requests. We should instead fallback to using the singular provider if this happens
Fixes subquery#1941
Type of change
Please delete options that are not relevant.
Checklist