Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable NFT for ServiceAgreementRegistry #254

Merged
merged 37 commits into from
Oct 10, 2023
Merged

Enable NFT for ServiceAgreementRegistry #254

merged 37 commits into from
Oct 10, 2023

Conversation

mzxyz
Copy link
Member

@mzxyz mzxyz commented Oct 5, 2023 •
edited
Loading

Changes

  • Enable NFT for service agreement registry
  • Remove establishServiceAgreement function to simplify the function call for creating agreements
  • Split indexer states and functions related from ServiceAgreementRegistry to IndexerServiceAgreement contract

Contract Size Changes

  • ServiceAgreementRegistry: 26KB -> 21KB
  • IndexerServiceAgreement : 8KB

Will fix the test cases in another PR

@mzxyz mzxyz changed the base branch from kepler-network to develop October 5, 2023 03:16
@mzxyz mzxyz requested a review from ianhe8x October 5, 2023 03:24
@mzxyz mzxyz requested a review from nz-neooo October 8, 2023 08:22
@ianhe8x
improve upgrade script to support matcher
4ac868a 
* remove scripts dependency on ./test/* so script can be debug with node --inspect -r ts-node/register -r tsconfig-paths/register
* update README
@ianhe8x
deploy latest planmanager to testnet
a455a1f
@ianhe8x
add planTemplate active check in acceptPlan, acceptOffer, renewAgreement
9f26885 
* update tests
* rename mmrRoot to poi
@ianhe8x
Merge pull request #256 from subquery/testnet-update-planmanager
c1b39b0 
deploy latest planmanager to testnet
@ianhe8x
Merge pull request #255 from subquery/improve-upgrade-script
26aa39c 
improve upgrade script to support matcher
@ianhe8x
refine Vesting tests
f32bc57
@ianhe8x
Copy link
Contributor

ianhe8x commented Oct 10, 2023

@mzxyz found an issue with renewAgreement

  1. transfer need to happen before createClosedServiceAgreement
  2. _establishServiceAgreement was called twice
  3. _establishServiceAgreement need to be called with checkThreshold=false

ianhe8x
ianhe8x previously requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@ianhe8x ianhe8x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renewAgreement need fix

@mzxyz mzxyz requested a review from ianhe8x October 10, 2023 23:54
@mzxyz mzxyz merged commit 1bfb16c into develop Oct 10, 2023
2 checks passed
@ianhe8x ianhe8x deleted the feat/service-agreement-nft branch October 10, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nz-neooo nz-neooo nz-neooo approved these changes

@ianhe8x ianhe8x Awaiting requested review from ianhe8x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzxyz @ianhe8x @nz-neooo