Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create project registry #247

Merged
merged 23 commits into from
Oct 5, 2023
Merged

Create project registry #247

merged 23 commits into from
Oct 5, 2023

Conversation

mzxyz
Copy link
Member

@mzxyz mzxyz commented Sep 20, 2023

Changes

  • Create ProjectRegistry contract
  • Support NFT features for ProjectRegistry
  • Remove unused functions

@mzxyz mzxyz requested a review from ianhe8x September 20, 2023 21:43
@mzxyz mzxyz changed the base branch from kepler-network to mainnet September 21, 2023 02:16
@ianhe8x
Copy link
Contributor

ianhe8x commented Sep 21, 2023

We can consider to support The enumeration extension is OPTIONAL for ERC-721 smart contracts (see “caveats”, below). This allows your contract to publish its full list of NFTs and make them discoverable.
https://eips.ethereum.org/EIPS/eip-721

@ianhe8x
Copy link
Contributor

ianhe8x commented Sep 25, 2023

@mzxyz have you added the change to merge indexing with ready?
also the change to allow indexer stop receiving new agreement

@mzxyz mzxyz requested a review from ianhe8x October 4, 2023 00:02
@mzxyz
Copy link
Member Author

mzxyz commented Oct 4, 2023

@ianhe8x In Solidity, when using super with multiple inheritance, the function calls are determined by the C3 linearization of the inheritance graph (or the C3 superclass linearization). In practice, it means that when you use super, the function that gets called is the next one in line based on the linearized order of inheritance, starting from the current contract and moving right to left through its base contracts. Once it finds and executes a matching function in this order, it stops.

https://docs.soliditylang.org/en/develop/contracts.html#multiple-inheritance-and-linearization

@mzxyz mzxyz requested a review from ianhe8x October 4, 2023 15:52
@mzxyz mzxyz merged commit 3c47370 into develop Oct 5, 2023
2 checks passed
@mzxyz mzxyz deleted the feat/project-registry branch October 17, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants