Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable price support2 #222

Merged
merged 18 commits into from
Aug 22, 2023
Merged

Stable price support2 #222

merged 18 commits into from
Aug 22, 2023

Conversation

ianhe8x
Copy link
Contributor

@ianhe8x ianhe8x commented Aug 4, 2023

No description provided.

@ianhe8x
Copy link
Contributor Author

ianhe8x commented Aug 10, 2023

@Jianzhuo We need to enhance security of oracle contract

  • Add controller role, owner can change controller. (because we might need to put the pk in a unsecured env so it runs automatically.
  • When controller set a price, we need to limit the change rate as well as interval
    • changes (+-)x% in y blocks, only owner can set these two parameters.
    • x default to 10, y default to 3600 (2 hrs)
  • Owner have a different method to set price, and without limitation

@ianhe8x ianhe8x requested a review from mzxyz August 16, 2023 22:11
contracts/PriceOracle.sol Outdated Show resolved Hide resolved
@mzxyz mzxyz merged commit 53cbbcd into kepler-network Aug 22, 2023
1 check passed
@ianhe8x ianhe8x deleted the stable_price_support2 branch August 22, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants