Update cas proxy signatures #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The phpCAS methods allow an array of URLs to be given for the service base. The previous implementation unnecessarily limited this package to a single string value. The package config file will now explode the value on commas, resulting in an array of possible values.
…onfig This allows us to pass a simple string into the phpCAS Client and Proxy methods, thereby avoiding autodiscovery. A comma separated list will be detected and split into an array when appropriate.
|
@subfission If you could find time to merge and tag this as a minor release, we would appreciate it. The overly strict signatures were a mistake on my part and it's causing issues. Thanks |
subfission
reviewed
Sep 12, 2024
subfission
reviewed
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy class added to facilitate testing used method signatures which do match the corresponding methods in the phpCAS class. This lead to issues with the service base argument not supporting all expected value types. The new signatures directly match the phpCAS class.