Preview window add "Close preview" button fix #469. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaboesch
force-pushed
the
closepreview
branch
from
315f245
to
7598f3c
Compare
timhunt
force-pushed
the
main
branch
3 times, most recently
from
cfaee3b
to
8f4fe71
Compare
lucaboesch
force-pushed
the
closepreview
branch
from
a674421
to
e049e17
Compare
lucaboesch
force-pushed
the
closepreview
branch
from
e049e17
to
38389df
Compare
|
StudentQuiz preview opens in a new pop-up window (or tab, as actually happens in modern browsers). Therefore, if a close button is added, it needs to close that window/tab, not what this does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please advise whether the button should appear only in Moodle ≥ 4.0.
I hope the remaining things are correct.
Best,
Luca