Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for stack suffix #78

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vespertilian
Copy link

No description provided.

we need to use the prod or dev env tags respectively for serving locally as remote layers are also prefixed
It’s useful to see what .env has been set if you are ever debugging.
@studds
Copy link
Owner

studds commented Aug 22, 2021

Hey @vespertilian sorry this really got away from me. Do you still need this?

@vespertilian
Copy link
Author

@studds Hey 👋 yeah maybe not. Also, this got away from me.

I think I mainly needed this for layers when developing locally.

Recently I upgraded to NX12 and all the things broke (but I didn't realise because and the old version was still being served from my dist folder), then I was trying to patch my version of NX-AWS but a lot has changed, NX improved a bunch of functions, moved to Webpack 5 and uses promises instead of observables.

So I have been setting up a vanilla NX build with run-commands, just going to set up my layers so they run locally. Trying to get the new pipelines feature for AWS-SAM working, which looks very good and you should check out if you have not already.

I am overall still keen on this project. Would be open to pair programming with you over a few days if you want to build a v2 I think I have the knowledge and context to be really helpful now. So let me know we should schedule some days next month if you're keen?

I hope your lockdown is going ok in VIC.

@studds
Copy link
Owner

studds commented Aug 22, 2021

I've just added support for nx12 over the weekend. I haven't been able to test it thoroughly, other than a very quick test on the example repo, so I've published v0.13.0 under the "next" tag. You can install via:

yarn add -D @nx-aws/sam@next @nx-aws/core@next @nx-aws/s3@next

or

npm i -D @nx-aws/sam@next @nx-aws/core@next @nx-aws/s3@next

Let me know how you go. Any issues, let me know here. Once I've had a chance to test a bit more, I'll publish to latest.

I think I'll have some more time for this in September, would love to get your input into a v1 (project is still on non-semver prerelease versions!)

Lockdown isn't too bad so far, but the numbers are going the wrong way. And yourself in Sydney?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants