Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAM1 update for timestamps #1216

Merged

Conversation

dukesook
Copy link
Contributor

@dukesook dukesook commented Jul 2, 2024

Sample File

This branch was used to create the following sample file.

'taic' - TAIClockInfoBox

aligned(8) class TAIClockInfoBox extends FullBox('taic', 0, 0) {
  unsigned int(64) time_uncertainty;
  unsigned int(32) clock_resolution;
  signed int(32) clock_drift_rate;
  unsigned int(2) clock_type;
  unsigned int(6) reserved = 0;
}

'itai' - TAITimestampBox

aligned(8) class TAITimestampBox extends ItemFullProperty('itai', 0, 0) {
	TAITimestampPacket timestamp_packet;
}

class TAITimestampPacket

aligned(8) class TAITimestampPacket {
  unsigned int(64) TAI_timestamp;
  unsigned int(1) synchronization_state;
  unsigned int(1) timestamp_generation_failure;
  unsigned int(1) timestamp_is_modified;
  unsigned int(5) reserved = 0;
}

@farindk
Copy link
Contributor

farindk commented Jul 3, 2024

Thank you. Looks good.
Are these changes in the draft expected to be finalized in the July MPEG meeting?

@dukesook
Copy link
Contributor Author

dukesook commented Jul 3, 2024

No, it will still take some time before the draft is finalized.

@farindk
Copy link
Contributor

farindk commented Jul 3, 2024

No, it will still take some time before the draft is finalized.

Ok, then we still keep it in the feature branch.

@farindk farindk merged commit 0dcc602 into strukturag:timestamp-properties Jul 3, 2024
2 checks passed
farindk added a commit that referenced this pull request Jul 3, 2024
@farindk
Copy link
Contributor

farindk commented Jul 3, 2024

I have made some small corrections and rebased the branch on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants