uncompressed: generic compression decode support #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bradh
force-pushed
the
generic_compression
branch
from
773c034 to
f0ddda8
Compare
|
Looks good to me. Let me know whether I should merge this now or wait until you have added the missing parts. |
|
Not yet. I think I'd like to handle the decompression earlier (in the same way we handle compressed metadata). This approach was fine for the case where the whole file is compressed, but turns out to be hard for the |
bradh
force-pushed
the
generic_compression
branch
2 times, most recently
from
b20e382 to
4efde38
Compare
bradh
changed the title
|
I think this is going to fail CIFuzz until google/oss-fuzz#12165 is merged |
farindk
reviewed
Jul 9, 2024
farindk
reviewed
Jul 9, 2024
farindk
reviewed
Jul 9, 2024
farindk
reviewed
Jul 9, 2024
farindk
reviewed
Jul 9, 2024
| #if WITH_DEFLATE_HEADER_COMPRESSION | ||
| #include <error.h> | ||
|
|
||
| #if WITH_ZLIB_COMPRESSION | ||
| std::vector<uint8_t> deflate(const uint8_t* input, size_t size); |
There was a problem hiding this comment.
Maybe deflate_zlib for consistency.
bradh
force-pushed
the
generic_compression
branch
from
1f54ffd to
86299ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from the draft Amendment 2 for ISO/IEC 23001-17. It re-uses and generalises the existing zlib support (from header compression), and adds an optional dependency on Brotli.
This version replaces #1194.
Feedback on the approach and internal API changes would be appreciated.
I still have some work to do on this:
There is no encoding support for this yet, and we'd likely need some kind of configuration option to specify that. It seems a bit premature given where the draft is up to.