Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo a message on setting PKG_CONFIG_PATH #1172

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Echo a message on setting PKG_CONFIG_PATH #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18b2736
Echo a message on setting PKG_CONFIG_PATH
wantehchang May 20, 2024
dad35f4
Replace `pwd` with $(pwd) for command substitution
wantehchang May 20, 2024
f0e1d3d
Clarify the Linux-specific path is just an example
wantehchang May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions third-party/aom.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ cmake -S . -B build.libavif -G Ninja -DCMAKE_INSTALL_PREFIX="$(pwd)/dist" -DCMAK
ninja -C build.libavif
ninja -C build.libavif install
cd ..

echo ""
echo "----- NOTE ----"
echo "Please add the path to the pkg-config file to your PKG_CONFIG_PATH, like this:"
echo "export PKG_CONFIG_PATH=\$PKG_CONFIG_PATH:$(pwd)/aom/dist/lib/pkgconfig"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path works on all platforms.

6 changes: 6 additions & 0 deletions third-party/dav1d.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,9 @@ meson build --default-library=static --buildtype release --prefix "$(pwd)/dist"
ninja -C build
ninja -C build install
cd ..

echo ""
echo "----- NOTE ----"
echo "Please add the path to the pkg-config file to your PKG_CONFIG_PATH. For"
echo "example, on Linux x86_64, run:"
echo "export PKG_CONFIG_PATH=\$PKG_CONFIG_PATH:$(pwd)/dav1d/dist/lib/x86_64-linux-gnu/pkgconfig"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Brad,

I copied this path from the comment at line 4. This path will only work on Linux x86_64. I can clarify that in the message. How about this?

Please add the path to the pkg-config file to your PKG_CONFIG_PATH. For example, on Linux x86_64, run:
export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:$(pwd)/dav1d/dist/lib/x86_64-linux-gnu/pkgconfig

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Loading