Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uuid property #1156

Closed
wants to merge 2 commits into from
Closed

Add uuid property #1156

wants to merge 2 commits into from

Conversation

dukesook
Copy link
Contributor

@dukesook dukesook commented Mar 26, 2024

I'm interested in adding uuid property getters/setters to enable user-defined image metadata.

@dukesook dukesook marked this pull request as draft March 26, 2024 22:08
heif_item_get_property_uuid()
@dukesook
Copy link
Contributor Author

I wasn't sure if adding a new Box_uuid class to box.h was a good idea. Instead, I extended the Box class to handle the uuid functionality.

Any feedback would be appreciated.

@farindk
Copy link
Contributor

farindk commented Jun 11, 2024

I wouldn't mix this with the base Box class, but introduce a catch-all Box_other class that keeps the data for everything that libheif does not (yet) understand. I wouldn't even make it uuid specific, but also for other (4cc) boxes that we do not parse yet.

@farindk
Copy link
Contributor

farindk commented Jun 11, 2024

I have implemented this in a slightly different way. It is now not limited to 'uuid' boxes anymore, but one can add all sorts of boxes with raw data, and also read the raw data of boxes that are not understood by libheif.

Only caveat at this time: we cannot read the raw data of boxes that were successfully parsed by libheif. This should be added, preferably by storing a pointer to the source data in the Box. But a clean implementation needs more time.

@farindk
Copy link
Contributor

farindk commented Jun 11, 2024

@dukesook Please review and if you think that this is ok, I'll close this PR.

@dukesook
Copy link
Contributor Author

dukesook commented Jun 11, 2024

@farindk
This is a great implementation, thanks for doing it. Go ahead and close this PR.

@farindk farindk closed this Jun 12, 2024
@dukesook dukesook deleted the uuid branch October 15, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants