add property by reference

strukturag · Nov 13, 2023 · 02b6f53 · 02b6f53
1 parent f2d30c3
commit 02b6f53
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/libheif/file.cc b/libheif/file.cc
@@ -986,7 +986,7 @@ void HeifFile::add_clap_property(heif_item_id id, uint32_t clap_width, uint32_t
 }
 
 
-heif_property_id HeifFile::add_property(heif_item_id id, std::shared_ptr<Box> property, bool essential)
+heif_property_id HeifFile::add_property(heif_item_id id, const std::shared_ptr<Box>& property, bool essential)
 {
   int index = m_ipco_box->append_child_box(property);
 

diff --git a/libheif/file.h b/libheif/file.h
@@ -170,7 +170,7 @@ class HeifFile
 
   void add_pixi_property(heif_item_id id, uint8_t c1, uint8_t c2 = 0, uint8_t c3 = 0);
 
-  heif_property_id add_property(heif_item_id id, std::shared_ptr<Box> property, bool essential);
+  heif_property_id add_property(heif_item_id id, const std::shared_ptr<Box>& property, bool essential);
 
   Result<heif_item_id> add_infe(const char* item_type, const uint8_t* data, size_t size);
-Original file line number
+Diff line change
@@ Expand Up @@
     }
-    heif_property_id HeifFile::add_property(heif_item_id id, std::shared_ptr<Box> property, bool essential)
+    heif_property_id HeifFile::add_property(heif_item_id id, const std::shared_ptr<Box>& property, bool essential)
     {
       int index = m_ipco_box->append_child_box(property);
@@ Expand Down @@