update userfaultfd handling. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
userfaultfd_handling_update
branch
from
feda1da
to
4ededc0
Compare
jvoisin
reviewed
Apr 13, 2024
src/iso_alloc_sanity.c
Outdated
|
|
||
| if(_uf_fd == ERR) { | ||
| LOG_AND_ABORT("This kernel does not support userfaultfd"); | ||
| LOG_AND_ABORT("This kernel does not support userfaultfd or disallowed in the user-space"); |
There was a problem hiding this comment.
Suggested change
| LOG_AND_ABORT("This kernel does not support userfaultfd or disallowed in the user-space"); | |
| LOG_AND_ABORT("This kernel does not support userfaultfd or is disallowed in the user-space"); |
devnexen
force-pushed
the
userfaultfd_handling_update
branch
from
4ededc0
to
c73c307
Compare
struct
reviewed
Apr 21, 2024
src/iso_alloc_sanity.c
Outdated
| int flags = O_CLOEXEC | O_NONBLOCK; | ||
|
|
||
| #ifdef UFFD_USER_MODE_ONLY | ||
| // Below, the syscall fails not necessarily because lack of kernel support. |
in multithread setting, reporting the thread id when appropriate. Also, allowing to work from the user-space perspective from Linux 5.11 so reports can me made from its own addresses ranges.
devnexen
force-pushed
the
userfaultfd_handling_update
branch
from
c73c307
to
d631286
Compare
struct
reviewed
Apr 21, 2024
| if(ioctl(_uf_fd, UFFDIO_API, &_uffd_api) == ERR) { | ||
| LOG_AND_ABORT("Failed to setup userfaultfd with ioctl"); | ||
| } | ||
|
|
||
| #if THREAD_SUPPORT | ||
| if(!(_uffd_api.features & UFFD_FEATURE_THREAD_ID)) { |
There was a problem hiding this comment.
Does the ioctl call reset this if it cannot be used?
There was a problem hiding this comment.
There was a problem hiding this comment.
Should we also check errno for -EFAULT here?
There was a problem hiding this comment.
not sure we really need to, return value is checked for ioctl already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in multithread setting, reporting the thread id when appropriate. Also, allowing to work from the user-space perspective from Linux 5.11
so reports can me made from its own addresses ranges.