Adds support for 'partner_id' in 'set_app_info' (#658)

* Adds support for 'partner_id' in 'set_app_info' Signed-off-by: zach wick <[email protected]>
stripe · Jun 28, 2018 · ab3949b · ab3949b
1 parent 32151d5
commit ab3949b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-02-23 14:17:07 +0100 using RuboCop version 0.50.0.
+# on 2018-06-28 10:59:56 -0400 using RuboCop version 0.50.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,18 +13,18 @@ Metrics/AbcSize:
 # Offense count: 27
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 496
+  Max: 498
 
 # Offense count: 8
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 624
+  Max: 626
 
 # Offense count: 11
 Metrics/CyclomaticComplexity:
   Max: 15
 
-# Offense count: 259
+# Offense count: 269
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
@@ -55,6 +55,6 @@ Style/ClassVars:
     - 'lib/stripe/stripe_object.rb'
     - 'test/stripe/api_resource_test.rb'
 
-# Offense count: 53
+# Offense count: 55
 Style/Documentation:
   Enabled: false
diff --git a/lib/stripe.rb b/lib/stripe.rb
@@ -213,10 +213,11 @@ def self.max_network_retries=(val)
   # with API requests. Useful for plugin authors to identify their plugin when
   # communicating with Stripe.
   #
-  # Takes a name and optional version and plugin URL.
-  def self.set_app_info(name, version: nil, url: nil)
+  # Takes a name and optional  partner program ID, plugin URL, and version.
+  def self.set_app_info(name, partner_id: nil, url: nil, version: nil)
     @app_info = {
       name: name,
+      partner_id: partner_id,
       url: url,
       version: version,
     }

diff --git a/test/stripe/stripe_client_test.rb b/test/stripe/stripe_client_test.rb
@@ -345,6 +345,7 @@ class StripeClientTest < Test::Unit::TestCase
             old = Stripe.app_info
             Stripe.set_app_info(
               "MyAwesomePlugin",
+              partner_id: "partner_1234",
               url: "https://myawesomeplugin.info",
               version: "1.2.34"
             )
@@ -361,6 +362,7 @@ class StripeClientTest < Test::Unit::TestCase
 
                 assert_equal({
                   name: "MyAwesomePlugin",
+                  partner_id: "partner_1234",
                   url: "https://myawesomeplugin.info",
                   version: "1.2.34",
                 }, data[:application])

diff --git a/test/stripe_test.rb b/test/stripe_test.rb
@@ -21,11 +21,13 @@ class StripeTest < Test::Unit::TestCase
       old = Stripe.app_info
       Stripe.set_app_info(
         "MyAwesomePlugin",
+        partner_id: "partner_1234",
         url: "https://myawesomeplugin.info",
         version: "1.2.34"
       )
       assert_equal({
         name: "MyAwesomePlugin",
+        partner_id: "partner_1234",
         url: "https://myawesomeplugin.info",
         version: "1.2.34",
       }, Stripe.app_info)