fix(config): update nelmio config for v4 #120
Open
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @millin-stripe since I saw you touch this repo recently, any interest in taking this change? we've been running with it as a local patch for some time now to avoid the log spam. |
cysp
force-pushed
the
cysp/nelmio-config
branch
from
53e92ae to
aec8451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NelmioApiDocBundle update from v3 to v4 in https://github.com/stripe/stripe-mirakl-connector/releases/tag/v3.0.3 updated its version of SwaggerPHP with accompanying BC breaks:
The visible breakage we saw was some log output telling us that these security annotations were no longer correct.