Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instant_or_skip verification for ACH #9695

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Nov 22, 2024

Summary

This pull request adds support for the instant_or_skip verification method for US bank accounts, and follows the iOS change to also show the correct mandate (without a microdeposits disclaimer) for these cases.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed         
          ├───────────┬───────────┬────────┼──────────┬──────────┬────────
 APK      │ old       │ new       │ diff   │ old      │ new      │ diff   
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼────────
      dex │   3.9 MiB │   3.9 MiB │ +408 B │  8.5 MiB │  8.5 MiB │ +780 B 
     arsc │   2.3 MiB │   2.3 MiB │    0 B │  2.3 MiB │  2.3 MiB │    0 B 
 manifest │     5 KiB │     5 KiB │    0 B │ 24.9 KiB │ 24.9 KiB │    0 B 
      res │ 904.1 KiB │ 904.1 KiB │    0 B │  1.4 MiB │  1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │    6 MiB │    6 MiB │    0 B 
    asset │   1.6 MiB │   1.6 MiB │   +5 B │  1.6 MiB │  1.6 MiB │   +5 B 
    other │   1.4 MiB │   1.4 MiB │   -1 B │  1.6 MiB │  1.6 MiB │    0 B 
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼────────
    total │  12.6 MiB │  12.6 MiB │ +412 B │ 21.5 MiB │ 21.5 MiB │ +785 B 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │  0           
 strings │ 40363 │ 40364 │ +1 (+4 -3)   
   types │ 13921 │ 13922 │ +1 (+1 -0)   
 classes │ 11606 │ 11607 │ +1 (+1 -0)   
 methods │ 59306 │ 59308 │ +2 (+22 -20) 
  fields │ 39545 │ 39552 │ +7 (+34 -27) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6197 │ 6197 │  0
APK
    compressed     │    uncompressed    │                                           
──────────┬────────┼───────────┬────────┤                                           
 size     │ diff   │ size      │ diff   │ path                                      
──────────┼────────┼───────────┼────────┼───────────────────────────────────────────
  3.9 MiB │ +408 B │   8.5 MiB │ +780 B │ ∆ classes.dex                             
  7.8 KiB │   +6 B │   7.6 KiB │   +6 B │ ∆ assets/dexopt/baseline.prof             
   50 KiB │   +5 B │   118 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
 53.3 KiB │   -3 B │ 118.1 KiB │    0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │   -2 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA                       
    270 B │   -1 B │     120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
    999 B │   -1 B │     867 B │   -1 B │ ∆ assets/dexopt/baseline.profm            
──────────┼────────┼───────────┼────────┼───────────────────────────────────────────
    4 MiB │ +412 B │   8.7 MiB │ +785 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   40363 │ 40364 │ +1 (+4 -3) 
  
  + La7/n;
  + VLZLZZLZLLZZL
  + onConnectionsForACHResult(Lcom/stripe/android/financialconnections/FinancialConnectionsSheetInternalResult;)V
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"5f6c6d6","r8-mode":"full","version":"8.7.14"}
  
  - VLZLZZLZLLZL
  - onConnectionsForACHResult(Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult;)V
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"16d1167","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   13921 │ 13922 │ +1 (+1 -0) 
  
  + La7/n;
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   59306 │ 59308 │ +2 (+22 -20) 
  
  + W5.f <init>(p, S0, i3, boolean)
  + W5.f <init>(p, S0, i3, boolean, int)
  + Z6.m <init>(S0, boolean)
  + a7.g <init>(S0, boolean)
  + a7.g g(Object) → Object
  + a7.h <init>(n, d)
  + a7.i <init>(n, S0, boolean, d)
  + a7.i f(Object, Object) → Object
  + a7.i n(d, Object) → d
  + a7.j <init>(n, c)
  + a7.k <init>(n, c, d)
  + a7.l <init>(v, n, d)
  + a7.m <init>(n, n, d)
  + a7.m f(Object, Object) → Object
  + a7.m n(d, Object) → d
  + a7.m p(Object) → Object
  + a7.n <init>(e, U, g, c, g, g0, d)
  + a7.n h(n, c) → Object
  + a7.n i(Throwable, c) → Object
  + a7.n j(r, c) → Object
  + d6.g <init>(I, boolean, a, boolean, boolean, j, boolean, FinancialConnectionsSessionManifest_Pane, i, boolean, boolean, i)
  + s5.t <init>(S0, boolean)
  
  - W5.f <init>(p, S0, i3)
  - W5.f <init>(p, S0, i3, int)
  - Z6.m <init>(S0)
  - a7.g <init>(m, d)
  - a7.g f(Object, Object) → Object
  - a7.g n(d, Object) → d
  - a7.g p(Object) → Object
  - a7.h <init>(m, S0, d)
  - a7.i <init>(m, c)
  - a7.j <init>(m, c, d)
  - a7.j f(Object, Object) → Object
  - a7.j n(d, Object) → d
  - a7.k <init>(v, m, d)
  - a7.l <init>(n, m, d)
  - a7.m <init>(e, U, g, c, g, g0, d)
  - a7.m h(m, c) → Object
  - a7.m i(Throwable, c) → Object
  - a7.m j(r, c) → Object
  - d6.g <init>(I, boolean, a, boolean, boolean, j, boolean, FinancialConnectionsSessionManifest_Pane, i, boolean, i)
  - s5.t <init>(S0)
  

FIELDS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   39545 │ 39552 │ +7 (+34 -27) 
  
  + W5.f g: boolean
  + Z6.m e: boolean
  + a7.g d: S0
  + a7.g e: boolean
  + a7.h h: int
  + a7.h i: n
  + a7.i i: int
  + a7.i j: n
  + a7.i k: S0
  + a7.i l: boolean
  + a7.j g: Object
  + a7.j i: Object
  + a7.j j: n
  + a7.j k: int
  + a7.k h: Object
  + a7.k i: int
  + a7.k j: n
  + a7.k k: c
  + a7.l i: v
  + a7.l j: n
  + a7.m h: int
  + a7.m i: n
  + a7.m j: n
  + a7.n d: e
  + a7.n e: U
  + a7.n f: g
  + a7.n g: c
  + a7.n h: g
  + a7.n i: g0
  + a7.n j: d
  + a7.n k: M
  + d6.g k: boolean
  + d6.g l: i
  + s5.t e: boolean
  
  - a7.g h: int
  - a7.g i: m
  - a7.h h: Object
  - a7.h i: int
  - a7.h j: m
  - a7.h k: S0
  - a7.i g: Object
  - a7.i i: Object
  - a7.i j: m
  - a7.i k: int
  - a7.j i: int
  - a7.j j: m
  - a7.j k: c
  - a7.k h: int
  - a7.k i: v
  - a7.k j: m
  - a7.l i: n
  - a7.l j: m
  - a7.m d: e
  - a7.m e: U
  - a7.m f: g
  - a7.m g: c
  - a7.m h: g
  - a7.m i: g0
  - a7.m j: d
  - a7.m k: M
  - d6.g k: i

@tillh-stripe tillh-stripe force-pushed the tillh/manual-entry-microdeposits-fix branch from 16e7772 to 3ed4818 Compare November 22, 2024 16:32
@tillh-stripe tillh-stripe force-pushed the tillh/manual-entry-microdeposits-fix branch 3 times, most recently from 455f21a to 4b20e07 Compare November 22, 2024 19:38
Introduce `FinancialConnectionsSheetInternalResult` and a `toPublicResult` method
@tillh-stripe tillh-stripe force-pushed the tillh/manual-entry-microdeposits-fix branch from 4b20e07 to 00a8114 Compare November 22, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant