Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
note that 403 nay be returned both when user is blocked and when app was no authorized different actions should be taken in both cases - if user gave no necessary oauth permission, then app should attempt log-in if user was blocked, then appropriate message should be shown especially in case of zero-hour blocks just relogging in may apparently swallow the attempted communication
- Loading branch information
a557a05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like an issue for openstreetmap-website, though. In StreetComplete, the user is forced to log in again. So, for login, the user is redirected to osm.org. That message should then be displayed in a modal way just after login and before authorizing StreetComplete.
And in case it is not a zero-hour block but a longer block, the message that led to the block would still be shown, only the openstreetmap-website doesn't forward the user to the oauth step. (In case the user is not allowed to create oauth tokens when blocked, that is.)
There is nothing we can do to differentiate if the error code is the same. We don't want to use the error message for logic, because as human readable text, we have to assume that that text could change anytime.
a557a05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://community.openstreetmap.org/t/is-this-the-same-person/123461/23 has a potential solution that is not absolutely terrible
still not sure is it good enough
I am now planning to experiment with blocking myself to see the behaviour in app