Skip to content

Commit

Permalink
bicycle parking: add option "floor" (fix #5191)
Browse files Browse the repository at this point in the history
  • Loading branch information
westnordost committed Jun 1, 2024
1 parent 8381c4c commit 2a6cdca
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 3 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
- _"Can you drop off parcels here?"_ (#5639), by @Arthur-GYT
- _"Is there a sign indicating access for mopeds on this bike path?"_ – asked exclusively in Belgium (#5567), by @PowerPlop

### Overlay improvements
- Bike paths: Now possible to select that cycling on footway is explicitly allowed or prohibited (#5575, #4913), by @wielandb
- Places: Entrances are shown to help with orientation (#5497)
- Things: Advertising totem was not displayed (#5588)

### Quest improvements

- Road Surface: Fix it was possible to answer track type and surface for a road in an endless loop (#5650)
Expand All @@ -17,6 +22,7 @@
- Power pole material: Can now answer with that power line is anchored to building (#5663), by @qugebert
- Tactile paving: Now enabled in Columbia (#5579)
- Prohibited for pedestrians: Clarified UI and wording (#5610)
- Bicycle parking: Add option for just markings on the ground (#5191)
- Drinking water: Don't ask for intermittent water sources (#5632), by @esilja
- Other small improvements and fixes (#5631, ...)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ enum class BikeParkingType(val osmValue: String) {
BUILDING("building"),
HANDLEBAR_HOLDER("handlebar_holder"),
TWO_TIER("two-tier"),
//FLOOR("floor"),
FLOOR("floor"),
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ private val BikeParkingType.titleResId: Int get() = when (this) {
BUILDING -> R.string.quest_bicycle_parking_type_building
HANDLEBAR_HOLDER -> R.string.quest_bicycle_parking_type_handlebarholder
TWO_TIER -> R.string.quest_bicycle_parking_type_two_tier
//FLOOR -> R.string.quest_bicycle_parking_type_floor
FLOOR -> R.string.quest_bicycle_parking_type_floor
}

private val BikeParkingType.iconResId: Int get() = when (this) {
Expand All @@ -25,5 +25,5 @@ private val BikeParkingType.iconResId: Int get() = when (this) {
BUILDING -> R.drawable.bicycle_parking_type_building
HANDLEBAR_HOLDER -> R.drawable.bicycle_parking_type_handlebarholder
TWO_TIER -> R.drawable.bicycle_parking_type_two_tier
//FLOOR -> R.drawable.quest_bicycle_parking_type_floor
FLOOR -> R.drawable.bicycle_parking_type_floor
}
1 change: 1 addition & 0 deletions app/src/main/res/authors.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ bicycle_parking_type_stand.jpg CC0 Mateusz Konieczny https://commo
bicycle_parking_type_wheelb... CC-BY-SA 4.0 Joxemai https://commons.wikimedia.org/wiki/File:Bizikletak_lotzekoa.JPG
bicycle_parking_type_handle... CC-BY-SA 4.0 Hiddewie https://commons.wikimedia.org/wiki/File:Bicycle_parking_handlebar_holder.jpg
bicycle_parking_type_two_ti... CC0 Bukk https://commons.wikimedia.org/wiki/File:Double_stack_bike_stand.jpg
bicycle_parking_type_floor CC0 Nakaner https://wiki.openstreetmap.org/wiki/File:Fahrradparkplatz_mit_Schild_und_ohne_Buegel.jpg

bicycle_rental_docking_stat... CC-BY-SA 3.0 Siyuwj https://commons.wikimedia.org/wiki/File:Bicycle_rental_site_of_Tiangongyuan_Station.JPG
bicycle_rental_dropoff_poin... CC-BY-SA 4.0 Alexander Migl https://commons.wikimedia.org/wiki/File:Stuttgart-Vaihingen_Train_Station_Mobility_Hub_IMG_5767.jpg
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 2a6cdca

Please sign in to comment.