-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update federated web identify to support multiple gsa ids #85
Conversation
Signed-off-by: lili <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is sort of breaking change by renaming the existing variable, I'd suggest using a new variable named streamnative_google_account_ids
, and mark the current streamnative_google_account_id
as deprecated.
And of course, we can do the rename directly if we're totally confident that no existing users will use current variable (we need check).
Signed-off-by: lili <[email protected]>
Signed-off-by: lili <[email protected]>
good idea, fixed, PTAL, thanks. |
🤖 I have created a release *beep* *boop* --- ## [3.14.0](v3.13.1...v3.14.0) (2024-07-02) ### Features * update federated web identify to support multiple gsa ids ([#85](#85)) ([bdf1df7](bdf1df7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Max Xu <[email protected]>
No description provided.