Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update federated web identify to support multiple gsa ids #85

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

urfreespace
Copy link
Member

@urfreespace urfreespace commented Jun 11, 2024

No description provided.

@urfreespace urfreespace self-assigned this Jun 11, 2024
@urfreespace urfreespace requested a review from a team as a code owner June 11, 2024 10:27
@urfreespace urfreespace requested a review from fantapsody June 11, 2024 10:34
@urfreespace urfreespace changed the title update federated web identify to support multiple ids feat: update federated web identify to support multiple ids Jun 11, 2024
@urfreespace urfreespace changed the title feat: update federated web identify to support multiple ids feat: update federated web identify to support multiple gsa ids Jun 11, 2024
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is sort of breaking change by renaming the existing variable, I'd suggest using a new variable named streamnative_google_account_ids, and mark the current streamnative_google_account_id as deprecated.

And of course, we can do the rename directly if we're totally confident that no existing users will use current variable (we need check).

Signed-off-by: lili <[email protected]>
Signed-off-by: lili <[email protected]>
@urfreespace
Copy link
Member Author

Since this is sort of breaking change by renaming the existing variable, I'd suggest using a new variable named streamnative_google_account_ids, and mark the current streamnative_google_account_id as deprecated.

And of course, we can do the rename directly if we're totally confident that no existing users will use current variable (we need check).

good idea, fixed, PTAL, thanks.

@urfreespace urfreespace merged commit bdf1df7 into main Jul 2, 2024
3 checks passed
@urfreespace urfreespace deleted the update-federate-multiple-ids branch July 2, 2024 23:54
maxsxu added a commit that referenced this pull request Jul 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.14.0](v3.13.1...v3.14.0)
(2024-07-02)


### Features

* update federated web identify to support multiple gsa ids
([#85](#85))
([bdf1df7](bdf1df7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants