Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update aws role session duration #71

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Feb 28, 2024

Motivation

Maximum session duration (in seconds) that you want to set for the specified role. If you do not specify a value for this setting, the default maximum of one hour is applied. This setting can have a value from 1 hour to 12 hours.

The default 1 hour is too short for debugging customer's issues.

Ref: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role#max_session_duration

@maxsxu maxsxu self-assigned this Feb 28, 2024
@maxsxu maxsxu requested a review from a team as a code owner February 28, 2024 08:00
Copy link

@ignacioli ignacioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job.

Copy link
Contributor

@AlvaroStream AlvaroStream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsxu maxsxu merged commit 0683fc6 into main Feb 28, 2024
4 checks passed
@maxsxu maxsxu deleted the max/update-aws-role-session branch February 28, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants