Update variables.tf #101
Open
Update variables.tf #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added validation for external_id
maxsxu
reviewed
Nov 25, 2024
| @@ -55,6 +55,11 @@ variable "external_id" { | |||
| default = "" | |||
| description = "A external ID that correspond to your Organization within StreamNative Cloud, used for all STS assume role calls to the IAM roles created by the module. This will be the organization ID in the StreamNative console, e.g. \"o-xhopj\"." | |||
| type = string | |||
|
|
|||
| validation { | |||
| condition = var.external_id == "" || can(regex("^o-", var.external_id)) | |||
There was a problem hiding this comment.
👋 Hi, @tendhar33 Very appreciate for your PR!
However we're unable to add the validation here since the StreamNative Cloud BYOC Pro customer can customize the Organization ID which can be any string.
Can I know what errors you encountered during using this module so we can have more accurate improvements? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation for external_id