Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version check to use github API and pull latest release #980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zand3r24
Copy link

Fixes #854

Motivation

install.sh references a static file inn the repo, stable.txt which hasn't been updated for some time. The install.sh script is referenced by other projects (I stumbled on this from the apache pulsar helm chart https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/scripts/pulsar/common_auth.sh#L61). This change would prevent anyone from having to update stable.txt manually again (at least as far as the install.sh script is concerned).

Modifications

version=$(curl -s https://api.github.com/repos/streamnative/pulsarctl/releases/latest | grep tag_name | sed -r 's/.(v[[:digit:]]+(.[[:digit:]]+)+)./\1/')

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • no-need-doc

This is an automated script.

@Zand3r24 Zand3r24 requested review from nodece and zymap as code owners January 31, 2023 22:07
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jan 31, 2023
@nodece
Copy link
Contributor

nodece commented Feb 6, 2023

The pulsarctl doesn't release separately, which releases with streamnative/pulsar, so there have multiple versions, so like: 2.9.x, 2.10.x, and 2.11.x, your command only downloads the latest version released recently, this version is not fixed, the version maybe is 2.10.x, or 2.11.x, or 2.9.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update stable version
2 participants