Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Set/get topic schema compatibility strategy #784

Closed
wants to merge 2 commits into from
Closed

[feature] Set/get topic schema compatibility strategy #784

wants to merge 2 commits into from

Conversation

teabot
Copy link

@teabot teabot commented Jul 14, 2022 •
edited
Loading

Fixes #783

Motivation

pulsarctl cannot be used to set topic level schema compatibility strategies.

Modifications

Added get/set commands for topic.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

  • I would argue that there should be tests for this and similar functionality, however currently there are none.

Documentation

Check the box below.

Need to update docs?

  • doc-required

  • no-need-doc

  • doc

    • Note: These specific commands were erroneously not listed in the Project status section of the README.
    • Added section on differences with pulsar-admin.

@teabot teabot requested review from nodece, zymap and a team as code owners July 14, 2022 15:31
@github-actions github-actions bot added the doc-required This pr needs a document label Jul 14, 2022
@teabot teabot mentioned this pull request Jul 14, 2022
Open
@github-actions github-actions bot added doc This pr contains a document and removed doc-required This pr needs a document labels Jul 14, 2022
nodece
nodece reviewed Jul 19, 2022
View reviewed changes
pkg/pulsar/topic.go
// SetSchemaCompatibilityStrategy sets the strategy used to check the a new schema provided
// by a producer is compatible with the current schema before it is installed
SetSchemaCompatibilityStrategy(topic utils.TopicName,
strategy utils.SchemaCompatibilityStrategy) error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a new structure SchemaCompatibilityStrategyV2, link to https://github.com/apache/pulsar/blob/master/pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/SchemaCompatibilityStrategy.java#L24

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you explain a little more? Are the values in each expected to differ? Or is a separate strategy required for another reason?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are different values here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll take a look

nodece
nodece suggested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good contribution! But you only add API methods, maybe you also need to add this feature for the CLI.

@teabot teabot closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodece nodece nodece requested changes

@zymap zymap Awaiting requested review from zymap zymap is a code owner

Assignees

@teabot teabot

Labels
doc This pr contains a document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operations regarding the schema compatibility modes are not supported.
2 participants
@teabot @nodece