Add retry for reconcile error #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 259 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 176 | 5 | 78 | 0 |
Click to see the invalid file list
- pkg/utils/event_source.go
- pkg/utils/event_source_test.go
- pkg/utils/retry.go
- pkg/utils/retry_test.go
- pkg/utils/suit_test.go
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
license-eye has totally checked 259 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 180 | 1 | 78 | 0 |
Click to see the invalid file list
- api/v1alpha1/zz_generated.deepcopy.go
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
labuladong
force-pushed
the
donglai/improve/add-retry
branch
from
f8b927d to
3a44039
Compare
There was a problem hiding this comment.
license-eye has totally checked 261 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 169 | 14 | 78 | 0 |
Click to see the invalid file list
- api/v1alpha1/zz_generated.deepcopy.go
- config/crd/bases/resource.streamnative.io_pulsarconnections.yaml
- config/crd/bases/resource.streamnative.io_pulsarfunctions.yaml
- config/crd/bases/resource.streamnative.io_pulsargeoreplications.yaml
- config/crd/bases/resource.streamnative.io_pulsarnamespaces.yaml
- config/crd/bases/resource.streamnative.io_pulsarpackages.yaml
- config/crd/bases/resource.streamnative.io_pulsarpermissions.yaml
- config/crd/bases/resource.streamnative.io_pulsarsinks.yaml
- config/crd/bases/resource.streamnative.io_pulsarsources.yaml
- config/crd/bases/resource.streamnative.io_pulsartenants.yaml
- config/crd/bases/resource.streamnative.io_pulsartopics.yaml
- config/rbac/role.yaml
- go.work
- go.work.sum
There was a problem hiding this comment.
license-eye has totally checked 261 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 169 | 14 | 78 | 0 |
Click to see the invalid file list
- api/v1alpha1/zz_generated.deepcopy.go
- config/crd/bases/resource.streamnative.io_pulsarconnections.yaml
- config/crd/bases/resource.streamnative.io_pulsarfunctions.yaml
- config/crd/bases/resource.streamnative.io_pulsargeoreplications.yaml
- config/crd/bases/resource.streamnative.io_pulsarnamespaces.yaml
- config/crd/bases/resource.streamnative.io_pulsarpackages.yaml
- config/crd/bases/resource.streamnative.io_pulsarpermissions.yaml
- config/crd/bases/resource.streamnative.io_pulsarsinks.yaml
- config/crd/bases/resource.streamnative.io_pulsarsources.yaml
- config/crd/bases/resource.streamnative.io_pulsartenants.yaml
- config/crd/bases/resource.streamnative.io_pulsartopics.yaml
- config/rbac/role.yaml
- go.work
- go.work.sum
config/crd/bases/resource.streamnative.io_pulsarconnections.yaml
Outdated
Show resolved
Hide resolved
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Suggested change
| --- | |
| # Copyright 2024 StreamNative | |
| # | |
| # Licensed under the Apache License, Version 2.0 (the "License"); | |
| # you may not use this file except in compliance with the License. | |
| # You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| --- |
config/crd/bases/resource.streamnative.io_pulsargeoreplications.yaml
Outdated
Show resolved
Hide resolved
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Suggested change
| --- | |
| # Copyright 2024 StreamNative | |
| # | |
| # Licensed under the Apache License, Version 2.0 (the "License"); | |
| # you may not use this file except in compliance with the License. | |
| # You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| --- |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Suggested change
| --- | |
| # Copyright 2024 StreamNative | |
| # | |
| # Licensed under the Apache License, Version 2.0 (the "License"); | |
| # you may not use this file except in compliance with the License. | |
| # You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| --- |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Suggested change
| --- | |
| # Copyright 2024 StreamNative | |
| # | |
| # Licensed under the Apache License, Version 2.0 (the "License"); | |
| # you may not use this file except in compliance with the License. | |
| # You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| --- |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Suggested change
| --- | |
| # Copyright 2024 StreamNative | |
| # | |
| # Licensed under the Apache License, Version 2.0 (the "License"); | |
| # you may not use this file except in compliance with the License. | |
| # You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| --- |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Suggested change
| --- | |
| # Copyright 2024 StreamNative | |
| # | |
| # Licensed under the Apache License, Version 2.0 (the "License"); | |
| # you may not use this file except in compliance with the License. | |
| # You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| --- |
labuladong
force-pushed
the
donglai/improve/add-retry
branch
from
3a44039 to
d6b1c45
Compare
freeznet
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator will only trigger reconciliation when there are k8s events. But for some temporary errors, it's better to have an exponential backoff policy.