Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: olm samples #174

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: olm samples #174

merged 1 commit into from
Dec 1, 2023

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Nov 30, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Signed-off-by: ericsyh <[email protected]>
@ericsyh ericsyh requested a review from a team as a code owner November 30, 2023 15:12
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Nov 30, 2023
@ericsyh
Copy link
Member Author

ericsyh commented Nov 30, 2023

@labuladong PTAL

@ericsyh ericsyh added this to the 0.4.5 milestone Dec 1, 2023
@ericsyh ericsyh requested review from a team and labuladong December 1, 2023 00:43
@labuladong labuladong merged commit 5579966 into main Dec 1, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-samples branch December 1, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants