Sync secret update #173
Merged
Sync secret update #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 218 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 144 | 1 | 73 | 0 |
Click to see the invalid file list
- config/samples/test-secert.yaml
github-actions
bot
removed
the
doc-info-missing
|
@labuladong:Thanks for providing doc info! |
There was a problem hiding this comment.
license-eye has totally checked 224 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 138 | 6 | 80 | 0 |
Click to see the invalid file list
- config/samples/geo/east.yaml
- config/samples/geo/geo.yaml
- config/samples/geo/local-connection.yaml
- config/samples/geo/remote-connection.yaml
- config/samples/geo/remote-secret.yaml
- config/samples/geo/west.yaml
labuladong
force-pushed
the
donglai/improve/sync-secret
branch
from
9cb8e5a to
8e85224
Compare
ericsyh
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pulsarconnectionobject will contain a secret ref. When the secret changes, the change will be observed and update to the broker cluster.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)