Skip to content

Commit

Permalink
fix ci
Browse files Browse the repository at this point in the history
  • Loading branch information
labuladong committed Jul 29, 2024
1 parent d511389 commit e53eff3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/connection/reconcile_topic.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func (r *PulsarTopicReconciler) Observe(ctx context.Context) error {

r.conn.topics = topicsList.Items
for i := range r.conn.topics {
if !IsPulsarTopicResourceReady(&r.conn.topics[i]) {
if !isPulsarTopicResourceReady(&r.conn.topics[i]) {
r.conn.addUnreadyResource(&r.conn.topics[i])
}
}
Expand Down Expand Up @@ -137,7 +137,7 @@ func (r *PulsarTopicReconciler) ReconcileTopic(ctx context.Context, pulsarAdmin
}
}

if IsPulsarTopicResourceReady(topic) &&
if isPulsarTopicResourceReady(topic) &&
!feature.DefaultFeatureGate.Enabled(feature.AlwaysUpdatePulsarResource) {
log.Info("Skip reconcile, topic resource is ready")
return nil
Expand Down Expand Up @@ -288,7 +288,7 @@ func (r *PulsarTopicReconciler) applyGeo(ctx context.Context, params *admin.Topi
return nil
}

func IsPulsarTopicResourceReady(topic *resourcev1alpha1.PulsarTopic) bool {
func isPulsarTopicResourceReady(topic *resourcev1alpha1.PulsarTopic) bool {
condition := meta.FindStatusCondition(topic.Status.Conditions, resourcev1alpha1.ConditionTopicPolicyReady)
return resourcev1alpha1.IsPulsarResourceReady(topic) && condition != nil && condition.Status == metav1.ConditionTrue
}
Expand Down

0 comments on commit e53eff3

Please sign in to comment.