remove the kube-rbac-proxy (#224)

* remove the kube-rbac-proxy Signed-off-by: ericsyh <[email protected]> * update the test Signed-off-by: ericsyh <[email protected]> * fix ci Signed-off-by: ericsyh <[email protected]> --------- Signed-off-by: ericsyh <[email protected]>
streamnative · Jul 27, 2024 · 93a49cb · 93a49cb
1 parent db53ac8
commit 93a49cb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 53 deletions.
diff --git a/charts/pulsar-resources-operator/README.md b/charts/pulsar-resources-operator/README.md
@@ -1,6 +1,4 @@
-# pulsar-resources-operator
-
-Pulsar Resources Operator Helm chart for Pulsar Resources Management on Kubernetes
+# Pulsar Resources Operator
 
 ![Version: v0.5.2](https://img.shields.io/badge/Version-v0.5.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.5.2](https://img.shields.io/badge/AppVersion-v0.5.2-informational?style=flat-square)
 

diff --git a/charts/pulsar-resources-operator/templates/deployment.yaml b/charts/pulsar-resources-operator/templates/deployment.yaml
@@ -44,24 +44,6 @@ spec:
       securityContext:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}
       containers:
-      - args:
-        - --secure-listen-address=0.0.0.0:8443
-        - --upstream=http://127.0.0.1:8080/
-        - --logtostderr=true
-        - --v=0
-        image: "{{ .Values.image.kubeRbacProxy.registry }}/{{ .Values.image.kubeRbacProxy.repository }}:{{ .Values.image.kubeRbacProxy.tag }}"
-        name: kube-rbac-proxy
-        ports:
-        - containerPort: 8443
-          name: https
-          protocol: TCP
-        resources:
-          limits:
-            cpu: 500m
-            memory: 128Mi
-          requests:
-            cpu: 5m
-            memory: 64Mi
       - args:
         - --health-probe-bind-address=:8081
         - --metrics-bind-address=127.0.0.1:8080

diff --git a/charts/pulsar-resources-operator/tests/deployment_test.yaml b/charts/pulsar-resources-operator/tests/deployment_test.yaml
@@ -28,39 +28,24 @@ tests:
           pattern: -pulsar-resources-operator$
       - equal:
           path: spec.template.spec.containers[0].image
-          value: gcr.io/kubebuilder/kube-rbac-proxy:v0.14.4
-      - equal:
-          path: spec.template.spec.containers[1].image
           value: docker.io/streamnative/pulsar-resources-operator:v0.5.2
       - equal:
-          path: spec.template.spec.containers[1].imagePullPolicy
+          path: spec.template.spec.containers[0].imagePullPolicy
           value: IfNotPresent
       - equal:
           path: spec.replicas
           value: 1
-      - equal:
-          path: spec.template.spec.containers[0].resources.requests.cpu
-          value: 5m
-      - equal:
-          path: spec.template.spec.containers[0].resources.requests.memory
-          value: 64Mi
-      - equal:
-          path: spec.template.spec.containers[0].resources.limits.cpu
-          value: 500m
-      - equal:
-          path: spec.template.spec.containers[0].resources.limits.memory
-          value: 128Mi
       - isNull:
-          path: spec.template.spec.containers[1].resources.requests
+          path: spec.template.spec.containers[0].resources.requests
       - isNull:
-          path: spec.template.spec.containers[1].resources.limits
+          path: spec.template.spec.containers[0].resources.limits
 
   - it: should update the image version successfully
     set:
       image.manager.tag: v0.5.2
     asserts:
       - equal:
-          path: spec.template.spec.containers[1].image
+          path: spec.template.spec.containers[0].image
           value: docker.io/streamnative/pulsar-resources-operator:v0.5.2
 
   - it: should update the replicas successfully
@@ -77,8 +62,8 @@ tests:
       resources.requests.memory: 128Mi
     asserts:
       - equal:
-          path: spec.template.spec.containers[1].resources.requests.cpu
+          path: spec.template.spec.containers[0].resources.requests.cpu
           value: 10m
       - equal:
-          path: spec.template.spec.containers[1].resources.requests.memory
+          path: spec.template.spec.containers[0].resources.requests.memory
           value: 128Mi
diff --git a/charts/pulsar-resources-operator/values.yaml b/charts/pulsar-resources-operator/values.yaml
@@ -35,15 +35,6 @@ image:
     # -- Image tag, it can override the image tag whose default is the chart appVersion.
     tag: ""
 
-  # kube-rbac-proxy container
-  kubeRbacProxy:
-    # -- Specififies the registry of images, especially when user want to use a different image hub
-    registry: gcr.io
-    # -- The full repo name for image.
-    repository: kubebuilder/kube-rbac-proxy
-    # -- Image tag, it can override the image tag whose default is the chart appVersion.
-    tag: "v0.14.4"
-
 # -- Specifies image pull secrets for private registry, the format is `- name: gcr`
 imagePullSecrets: []
 # If you want to specify secrets, follow this format
@@ -59,7 +50,6 @@ nameOverride: ""
 # -- It will override the name of deployment
 fullnameOverride: ""
 
-
 serviceAccount:
   # -- Specifies whether a service account should be created
   create: true
@@ -107,7 +97,6 @@ resources: {}
 # -- Add NodeSelector for pod schedule
 nodeSelector: {}
 
-
 # -- Add tolerations
 tolerations: []