Skip to content

Commit

Permalink
feat: TLS authentication
Browse files Browse the repository at this point in the history
  • Loading branch information
tomjo committed Nov 15, 2023
1 parent 4041f93 commit 8a574a0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion pkg/admin/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ func NewPulsarAdmin(conf PulsarAdminConfig) (PulsarAdmin, error) {
if err != nil {
return nil, err
}
adminClient = admin.NewWithAuthProvider(config, oauthProvider)
} else if conf.Token != "" {
config.Token = conf.Token

Expand Down
2 changes: 1 addition & 1 deletion pkg/connection/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func (r *PulsarConnectionReconciler) MakePulsarAdminConfig(ctx context.Context)
}

// MakePulsarAdminConfig create pulsar admin configuration
func (r *PulsarConnectionReconciler) MakePulsarAdminConfig(ctx context.Context, connection *resourcev1alpha1.PulsarConnection,
func MakePulsarAdminConfig(ctx context.Context, connection *resourcev1alpha1.PulsarConnection,
k8sClient client.Client) (*admin.PulsarAdminConfig, error) {
if connection.Spec.AdminServiceURL == "" && connection.Spec.AdminServiceSecureURL == "" {
return nil, fmt.Errorf("adminServiceURL or adminServiceSecureURL must not be empty")
Expand Down

0 comments on commit 8a574a0

Please sign in to comment.