Update snappy dependency #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@horizonzy @hangc0276 please review |
horizonzy
previously approved these changes
Oct 31, 2023
| @@ -250,6 +250,12 @@ | |||
| <version>${slf4j.version}</version> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
To follow the code style, we can define the snappy-java in the dependencyManagement, then refer the snappy-java in the dependencies.
hangc0276
previously approved these changes
Nov 1, 2023
|
LGTM. Thanks. |
horizonzy
approved these changes
Nov 1, 2023
hangc0276
approved these changes
Nov 1, 2023
zymap
pushed a commit
that referenced
this pull request
Nov 10, 2023
* add snappy dependency * change exception to throwable * follow code style for dependency management (cherry picked from commit 3cb63a8)
zymap
pushed a commit
that referenced
this pull request
Nov 10, 2023
* add snappy dependency * change exception to throwable * follow code style for dependency management (cherry picked from commit 3cb63a8)
|
cherry-picked to branch-3.1 and branch-3.0 |
hangc0276
pushed a commit
that referenced
this pull request
Nov 14, 2023
* add snappy dependency * change exception to throwable * follow code style for dependency management (cherry picked from commit 3cb63a8)
hangc0276
pushed a commit
that referenced
this pull request
Nov 14, 2023
* add snappy dependency * change exception to throwable * follow code style for dependency management (cherry picked from commit 3cb63a8)
|
cherry-picked to branch-2.11 and branch-2.10.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444
Motivation
Solve dependency issue to allow Lakehouse Sink Connector to write to local delta tables.
Modifications
Added a snappy dependency to work with M1 Macbook and changed
exceptiontothrowablein SinkWriter.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)