Skip to content

Commit

Permalink
Revert "upgrade jdk17. (#122)"
Browse files Browse the repository at this point in the history
This reverts commit b299c40.
  • Loading branch information
hangc0276 committed Feb 28, 2023
1 parent bb17567 commit 33e67a5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 20 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/pr-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,10 @@ jobs:

steps:
- uses: actions/checkout@v1

- name: Set up JDK 17
uses: actions/setup-java@v2
if: ${{ needs.changed_files_job.outputs.docs_only != 'true' }}
- name: Set up JDK 1.8
uses: actions/setup-java@v1
with:
distribution: 'temurin'
java-version: 17
java-version: 1.8

- name: License check
run: mvn -ntp -B license:check
Expand Down
24 changes: 10 additions & 14 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@
<description>It is a lakehouse connector streaming convert data between lakehouse and Apache Pulsar.</description>

<properties>
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
<java.version>17</java.version>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<java.version>1.8</java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
<spotbugs-annotations.version>4.2.2</spotbugs-annotations.version>
<spotbugs-annotations.version>3.1.8</spotbugs-annotations.version>
<testRetryCount>0</testRetryCount>

<!-- connector dependencies -->
Expand Down Expand Up @@ -71,11 +71,11 @@
<!-- build plugin dependencies -->
<license.plugin.version>3.0</license.plugin.version>
<maven-checkstyle-plugin.version>3.1.2</maven-checkstyle-plugin.version>
<maven-compiler-plugin.version>3.10.1</maven-compiler-plugin.version>
<surefire.version>3.0.0-M3</surefire.version>
<maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
<maven-surefire-plugin.version>2.21.0</maven-surefire-plugin.version>
<nifi.nar.plugin.version>1.2.0</nifi.nar.plugin.version>
<puppycrawl.checkstyle.version>8.37</puppycrawl.checkstyle.version>
<spotbugs-maven-plugin.version>4.2.2</spotbugs-maven-plugin.version>
<spotbugs-maven-plugin.version>3.1.8</spotbugs-maven-plugin.version>
<cloudPkgSuffix></cloudPkgSuffix>
</properties>

Expand Down Expand Up @@ -564,7 +564,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven-compiler-plugin.version}</version>
<configuration>
<encoding>UTF-8</encoding>
<source>${java.version}</source>
<target>${java.version}</target>
<compilerArgs>
<compilerArg>-Xlint:deprecation</compilerArg>
<compilerArg>-Xlint:unchecked</compilerArg>
Expand All @@ -577,17 +578,12 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
<configuration>
<redirectTestOutputToFile>${redirectTestOutputToFile}</redirectTestOutputToFile>
<reuseForks>false</reuseForks>
<forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>
<rerunFailingTestsCount>${testRetryCount}</rerunFailingTestsCount>
<argLine>
--add-opens java.base/java.util=ALL-UNNAMED
--add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.util.concurrent=ALL-UNNAMED
--add-opens java.base/java.nio=ALL-UNNAMED
</argLine>
</configuration>
</plugin>
<!-- package -->
Expand Down

0 comments on commit 33e67a5

Please sign in to comment.