add support for commas in param values

cmd/substreams/gui.go

@@ -31,7 +31,7 @@ func init() {
 	guiCmd.Flags().StringSlice("debug-modules-initial-snapshot", nil, "List of 'store' modules from which to print the initial data snapshot (Unavailable in Production Mode")
 	guiCmd.Flags().StringSlice("debug-modules-output", nil, "List of extra modules from which to print outputs, deltas and logs (Unavailable in Production Mode)")
 	guiCmd.Flags().Bool("production-mode", false, "Enable Production Mode, with high-speed parallel processing")
-	guiCmd.Flags().StringSliceP("params", "p", nil, "Set a params for parameterizable modules. Commas are argument delimiters and cannot be used within the parameter value. Can be specified multiple times. Ex: -p module1=valA -p module2=valX&valY")
+	guiCmd.Flags().StringArrayP("params", "p", nil, "Set a params for parameterizable modules. Can be specified multiple times. Ex: -p module1=valA -p module2=valX&valY")
 	guiCmd.Flags().Bool("replay", false, "Replay saved session into GUI from replay.bin")
 	rootCmd.AddCommand(guiCmd)
 }

cmd/substreams/run.go

@@ -31,7 +31,7 @@ func init() {
 	runCmd.Flags().StringSlice("debug-modules-initial-snapshot", nil, "List of 'store' modules from which to print the initial data snapshot (Unavailable in Production Mode)")
 	runCmd.Flags().StringSlice("debug-modules-output", nil, "List of modules from which to print outputs, deltas and logs (Unavailable in Production Mode)")
 	runCmd.Flags().Bool("production-mode", false, "Enable Production Mode, with high-speed parallel processing")
-	runCmd.Flags().StringSliceP("params", "p", nil, "Set a params for parameterizable modules. Commas are argument delimiters and cannot be used within the parameter value. Can be specified multiple times. Ex: -p module1=valA -p module2=valX&valY")
+	runCmd.Flags().StringArrayP("params", "p", nil, "Set a params for parameterizable modules. Can be specified multiple times. Ex: -p module1=valA -p module2=valX&valY")
 	runCmd.Flags().String("test-file", "", "runs a test file")
 	runCmd.Flags().Bool("test-verbose", false, "print out all the results")
 	rootCmd.AddCommand(runCmd)

docs/release-notes/change-log.md

@@ -30,6 +30,7 @@ This release fixes data determinism issues. This comes at a 20% performance cost
 
 * Changed default WASM engine from `wasmtime` to `wazero`, use `SUBSTREAMS_WASM_RUNTIME=wasmtime` to revert to prior engine. Note that `wasmtime` will now run a lot slower than before because resetting the memory in `wasmtime` is more expensive than in `wazero`.
 * Execution of modules is now done in parallel within a single instance, based on a tree of module dependencies.
+* The `substreams gui` and `substreams run` now accept commas inside a `param` value. For example: `substreams run --param=p1=bar,baz,qux --param=p2=foo,baz`. However, you can no longer pass multiple parameters using an ENV variable, or a `.yaml` config file.
 
 ## [v1.1.4](https://github.com/streamingfast/substreams/releases/tag/v1.1.4)
 

tools/tier2call.go

@@ -25,7 +25,7 @@ func init() {
 	tier2CallCmd.Flags().Bool("insecure", false, "Skip certificate validation on GRPC connection")
 	tier2CallCmd.Flags().Bool("plaintext", false, "Establish GRPC connection in plaintext")
 
-	tier2CallCmd.Flags().StringSliceP("params", "p", nil, "Set a params for parameterizable modules. Commas are argument delimiters and cannot be used within the parameter value. Can be specified multiple times. Ex: -p module1=valA -p module2=valX&valY")
+	tier2CallCmd.Flags().StringArrayP("params", "p", nil, "Set a params for parameterizable modules. Can be specified multiple times. Ex: -p module1=valA -p module2=valX&valY")
 
 	Cmd.AddCommand(tier2CallCmd)
 }