added new flags to configure flush intervals #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoueh
requested changes
Dec 2, 2024
Co-authored-by: Matthieu Vachon <[email protected]>
Co-authored-by: Matthieu Vachon <[email protected]>
fschoell
force-pushed
the
feature/flush_configurations
branch
from
485ece9 to
3459d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this reworks some flush intervals to account Clickhouse specific loading improvements. Notable changes:
--batch-row-flush-intervalhas been added to ensure optimal flush sizes for Clickhouse (recommended flush size is between 10k and 100k rows for bulk inserts)--live-block-flush-intervalhas been added to allow reducing the number of flushes on fast block chains (Clickhouse recommends to not do more than one insert per second)--flush-intervalhas been renamed to--batch-block-flush-intervalto following the same naming convention