Skip to content

Commit

Permalink
Fixed duration not printed correctly in console reader stats
Browse files Browse the repository at this point in the history
  • Loading branch information
maoueh committed Mar 7, 2024
1 parent 685f663 commit 7217bbd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). See [MAINTAINERS.md](./MAINTAINERS.md)
for instructions to keep up to date.

## Unreleased

* Fixed `reader block stats` to print properly time of importing block.

## [1.1.13](https://github.com/streamingfast/firehose-near/releases/tag/v1.1.12)

### Substreams
Expand All @@ -20,10 +24,10 @@ for instructions to keep up to date.

> [!IMPORTANT]
> We have had reports of older versions of this software creating corrupted merged-blocks-files (with duplicate or extra out-of-bound blocks)
> This release adds additional validation of merged-blocks to prevent serving duplicate blocks from the firehose or substreams service.
> This release adds additional validation of merged-blocks to prevent serving duplicate blocks from the firehose or substreams service.
> This may cause service outage if you have produced those blocks or downloaded them from another party who was affected by this bug.
1. Find the affected files by running the following command (can be run multiple times in parallel, over smaller ranges)
1. Find the affected files by running the following command (can be run multiple times in parallel, over smaller ranges)

```
tools check merged-blocks-batch <merged-blocks-store> <start> <stop>
Expand Down
2 changes: 1 addition & 1 deletion codec/consolereader.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func newParsingStats(block uint64) *parsingStats {
func (s *parsingStats) log() {
zlog.Info("reader block stats",
zap.Uint64("block_num", s.blockNum),
zap.Int64("duration", int64(time.Since(s.startAt))),
zap.Duration("duration", time.Since(s.startAt)),
zap.Reflect("stats", s.data),
)
}
Expand Down

0 comments on commit 7217bbd

Please sign in to comment.