Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Remove members only option from dropdown #3147

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MaximilianoRicoTabo
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Hook on Access Plan action to add a jQuery snippet that removes the not wanted option in case streamline setting is checked.

Resolves #3088

How to test the changes in this Pull Request:

See related issue for reproduce steps.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@ideadude
Copy link
Member

I think we can get the LifterLMS team to add a filter for us, so we don't have to use JS to remove this value (kind of hacky).

Do you know where in the LifterLMS code we would want that filter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Access Plan > Plan Availability > Members-only settings on Access Plans metabox
2 participants