Skip to content

Commit

Permalink
simpler
Browse files Browse the repository at this point in the history
  • Loading branch information
Reecepbcups committed Feb 9, 2024
1 parent 30f90e9 commit d4ca3c9
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -618,8 +618,6 @@ func NewApp(
// we prefer to be more strict in what arguments the modules expect.
skipGenesisInvariants := cast.ToBool(appOpts.Get(crisis.FlagSkipGenesisInvariants))

bondDenom := app.GetChainBondDenom()

// NOTE: Any module instantiated in the module manager that is later modified
// must be passed by reference here.
app.ModuleManager = module.NewManager(
Expand Down Expand Up @@ -653,7 +651,7 @@ func NewApp(
ibcfee.NewAppModule(app.IBCFeeKeeper),
ica.NewAppModule(&app.ICAControllerKeeper, &app.ICAHostKeeper),
ibctm.NewAppModule(),
globalfee.NewAppModule(appCodec, app.GlobalFeeKeeper, bondDenom),
globalfee.NewAppModule(appCodec, app.GlobalFeeKeeper),
// sdk
crisis.NewAppModule(app.CrisisKeeper, skipGenesisInvariants, app.GetSubspace(crisistypes.ModuleName)), // always be last to make sure that it checks for all invariants and not only part of them
)
Expand Down
2 changes: 1 addition & 1 deletion x/globalfee/genesis_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func TestInitExportGenesis(t *testing.T) {
for name, spec := range specs {
t.Run(name, func(t *testing.T) {
ctx, encCfg, keeper := setupTestStore(t)
m := NewAppModule(encCfg.Codec, keeper, "stake")
m := NewAppModule(encCfg.Codec, keeper)
m.InitGenesis(ctx, encCfg.Codec, []byte(spec.src))
gotJSON := m.ExportGenesis(ctx, encCfg.Codec)
var got types.GenesisState
Expand Down
2 changes: 0 additions & 2 deletions x/globalfee/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,10 @@ func (AppModule) IsOnePerModuleType() {
func NewAppModule(
cdc codec.Codec,
keeper keeper.Keeper,
debondDenom string,
) *AppModule {
return &AppModule{
AppModuleBasic: AppModuleBasic{cdc: cdc},
keeper: keeper,
bondDenom: debondDenom,
}
}

Expand Down

0 comments on commit d4ca3c9

Please sign in to comment.