Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in documentation #326

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

fix: typos in documentation #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6e0cd1
Feat/make isRegistered public (#311)
DonFungible Nov 11, 2024
8113115
[feat] add codeowners for pr review (#316)
AndyBoWu Nov 13, 2024
456fc3d
Implement multicall (#314)
bonnie57 Nov 13, 2024
34340f1
typo Update CONTRIBUTING.md
evg1nn-eth Nov 28, 2024
797dd6d
typos Update README.md
evg1nn-eth Nov 28, 2024
56e53ad
typo Update README.MD
evg1nn-eth Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @DonFungible @edisonz0718 @jacob-tucker @AndyBoWu
* @LeoHChen @DonFungible @edisonz0718 @jacob-tucker @AndyBoWu
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Please make sure to read and observe our [Code of Conduct](/CODE_OF_CONDUCT.md).

We welcome feedback with or without pull requests. If you have an idea for how
to improve the project, great! All we ask is that you take the time to write a
clear and concise explanation of what need you are trying to solve. If you have
clear and concise explanation of what need that you are trying to solve. If you have
thoughts on _how_ it can be solved, include those too!

The best way to see a feature added, however, is to submit a pull request.
Expand Down Expand Up @@ -63,4 +63,4 @@ To make it easier for your PR to receive reviews, consider the reviewers will ne

[1]: https://github.com/storyprotocol/typescript-sdk/issues
[2]: https://chris.beams.io/posts/git-commit/#seven-rules
[3]: https://google.github.io/styleguide/tsguide.html
[3]: https://google.github.io/styleguide/tsguide.html
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const PRIVATE_KEY = process.env.WALLET_PRIVATE_KEY || "0x";
const account = privateKeyToAccount(WALLET_PRIVATE_KEY as Address);
```

The preceding code created the `account` object for creating the SDK client.
The preceding code creates the `account` object for the SDK client.

## Set up SDK client

Expand Down Expand Up @@ -81,7 +81,7 @@ Under the `typescript-sdk/packages/core-sdk` directory:

- Navigate to the `core-sdk` directory.
- Execute `npm run build` to build your latest code.
- Run `yalc publish`. You should see a message like `@story-protocol/core-sdk@<version> published in store.` (Note: The version number may vary).
- Run `yalc publish`. You should see a message like `@story-protocol/core-sdk@<version> published in the store.` (Note: The version number may vary).

To set up your testing environment (e.g., a new Next.js project), use `yalc add @story-protocol/core-sdk@<version>` (ensure the version number is updated accordingly).

Expand Down
2 changes: 1 addition & 1 deletion packages/core-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@story-protocol/core-sdk",
"version": "1.2.0-rc.1",
"version": "1.2.0-rc.2",
"description": "Story Protocol Core SDK",
"main": "dist/story-protocol-core-sdk.cjs.js",
"module": "dist/story-protocol-core-sdk.esm.js",
Expand Down
Loading
Loading