Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

OpenSea Collection Fix & Minor Refactors #121

Merged
merged 11 commits into from
Feb 19, 2024
Merged

OpenSea Collection Fix & Minor Refactors #121

merged 11 commits into from
Feb 19, 2024

Conversation

jdubpark
Copy link
Contributor

@jdubpark jdubpark commented Feb 18, 2024 •
edited
Loading

@jdubpark jdubpark requested a review from a team February 18, 2024 22:48
@jdubpark jdubpark marked this pull request as ready for review February 18, 2024 22:56
LeoHChen
LeoHChen suggested changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate PR for that release logs. All other changes shall be merged at first

@jdubpark jdubpark requested a review from LeoHChen February 18, 2024 23:05
LeoHChen
LeoHChen suggested changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take out the deployment addresses as well. Thanks

@jdubpark jdubpark force-pushed the beta-deploy-with-fix branch from 6880dd0 to 54729ae Compare February 18, 2024 23:44
@jdubpark jdubpark requested a review from LeoHChen February 18, 2024 23:45
@LeoHChen
Copy link
Contributor

Please rename the PR to mention the proper changes.

LeoHChen
LeoHChen reviewed Feb 18, 2024
View reviewed changes
Copy link
Contributor

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the name of the PR accordingly. Thanks

contracts/interfaces/modules/royalty/IRoyaltyModule.sol Show resolved Hide resolved
deploy-out/deployment-11155111.json Outdated Show resolved Hide resolved
@jdubpark jdubpark changed the title Beta deploy with Patches OpenSea Collection Fix & Minor Refactors Feb 18, 2024
LeoHChen
LeoHChen approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

@LeoHChen LeoHChen merged commit c4b34c5 into storyprotocol:main Feb 19, 2024
1 check passed
This was referenced Feb 19, 2024
Closed
Closed
kingster-will referenced this pull request in kingster-will/protocol-core-v1-dev Mar 19, 2024
@jdubpark @Spablob @kingster-will
OpenSea Collection Fix & Minor Refactors (storyprotocol#121)
6f28a30 
* fix: owner, name, and symbol for OpenSea rendering

* fix: beta-rc4 deployment

* fix royalty related
* fix: NatSpec and unused event

* refactor: rename royalty & dispute module folder

* fix: rename test files for PIL

---------

Co-authored-by: Spablob <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeoHChen LeoHChen LeoHChen approved these changes

@kingster-will kingster-will kingster-will approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdubpark @LeoHChen @kingster-will @Spablob