-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
1 similar comment
* be a list of {@link IdSiteModel} objects. | ||
* | ||
*/ | ||
Tenant.prototype.getIdSiteModels = function getTenantIdSiteModels(/* [options,] callback */) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be getIdSites()
instead of getIdSiteModels()
. Your reasoning is correct. But the underlying model is named incorrectly so we'll have to fix that in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding this, I was following a comment in the IdSiteModel class file which references {@link Tenant#getIdSiteModels Tenant.getIdSiteModels()}
(which did not exist at the time). Updating this as well.
Besides my comments this PR is looking good! 👍 |
@Tweety-FER Awesome. Thank you! I'm happy with the changes. Noticed a small typo in the tests (Tennant -> Tenant). But I fixed that. Going to merge this in. 🎉 |
I'm pulling this PR and it's issue onto the backlog, as this will be part of 1.0, so I don't want to visualize it on the board right now |
Add support for getting a list of Tenant's Id Sites, as well as a helper directly on
Client
, as well as tests for these features.Usage example:
Fixes #424
Count not drag the card as I am not a collaborator.