LVMPV format size #1334
Open
LVMPV format size #1334
+214
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for a special code for this, we can reuse the existing code from LVM static data.
Unfortunately LVM substracts VG metadata from the reported PV size so we need to make sure to update the size after the vgextend and vgreduce operation.
For existing PVs we need to check the format size instead of simply expecting the format is fully resized to match the size of the underlying block device.
|
I ran some LVM and autopart kickstart tests on this and together with the new tests I added, I am pretty sure this shouldn't break anything, so marking this a s ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the LVM code to check the actual LVM PV format size instead of assuming it's always the same size as the underlying block device.
Fixes: #1320