Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): include tslib #45

Merged
merged 1 commit into from
May 13, 2020
Merged

chore(deps): include tslib #45

merged 1 commit into from
May 13, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented May 12, 2020

Fixes #36
Lodash was not used.

@P0lip P0lip added the dependencies Pull requests that update a dependency file label May 12, 2020
@P0lip P0lip requested a review from a team May 12, 2020 22:44
@P0lip P0lip self-assigned this May 12, 2020
Copy link

@marcelltoth marcelltoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P0lip P0lip merged commit a0545bb into master May 13, 2020
@P0lip P0lip deleted the fix/tslib-dep branch May 13, 2020 09:25
@marcelltoth
Copy link

marcelltoth commented May 13, 2020

We should probably check the other packages have the same problem. Unless explicitly overridden, all of our packages are compiled with importHelpers: true, so we should make sure tslib is referenced everywhere. I will do that.

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marcelltoth
Copy link

Pinging @marbemac to double check that this is a possible issue in all of our repos, right?

@P0lip
Copy link
Contributor Author

P0lip commented May 13, 2020

Pinging @marbemac to double check that this is a possible issue in all of our repos, right?

Yes and no.
Some repose such as jsv, markdown or json use rollup, so they are not prone to this issue.
Although, there are some that in fact may lack the dependency, yet I'd say it's rather not too common, hopefully.

@P0lip
Copy link
Contributor Author

P0lip commented May 13, 2020

I think JSE is one of the dependency that does rely on tslib, but doesn't have it listed, but it's a private component, and hence is not used in a plain JS project.
I'll add that dependency there later today though, as I'll need to update @stoplight/json package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tslib dependency
3 participants